Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #33 #34

Merged

Conversation

hangie
Copy link

@hangie hangie commented Apr 4, 2024

This piece of code:

customPath = path.normalize(customPath);

If run on: ${workspaceFolder}/../venv/bin/vale
would result in: venv/bin/vale

The normalize needs to be run after the expansion to achieve the correct result.

@ChrisChinchilla
Copy link
Owner

Ok, thanks @hangie I'll do some testing. This isn't a feature I use, but I know others use the binary locations quite a bit.

Copy link
Owner

@ChrisChinchilla ChrisChinchilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@ChrisChinchilla ChrisChinchilla merged commit d499576 into ChrisChinchilla:main Apr 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants