Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regex-tdfa-1.2.3.3 violates PVP contract #29

Closed
phadej opened this issue Sep 28, 2019 · 2 comments
Closed

regex-tdfa-1.2.3.3 violates PVP contract #29

phadej opened this issue Sep 28, 2019 · 2 comments

Comments

@phadej
Copy link

phadej commented Sep 28, 2019

-(=~~) x r = do let make :: (RegexMaker Regex CompOption ExecOption a, Monad m) => a -> m Regex
+(=~~) x r = do let make :: (RegexMaker Regex CompOption ExecOption a, Fail.MonadFail m) => a -> m Regex

is a more demanding type-signature (and thus breaking) change and might cause difficult to track compilation errors.

This feels minor, but the 1.2.3.3 should been 1.3. You'll break pre-GHC-8.6 users which use =~~ with not MonadFail monads.

@neongreen
Copy link
Collaborator

Hm, agreed. I released 1.3.0 and deprecated 1.2.3.3.

@phadej
Copy link
Author

phadej commented Sep 29, 2019

@neongreen thanks for prompt response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants