Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix equality to require identical types #51

Merged
merged 3 commits into from
Jun 7, 2017
Merged

Conversation

dsyme
Copy link
Collaborator

@dsyme dsyme commented Jun 7, 2017

@ChrisMarinos Here is a fix for #15 if you agree

Basically it checks that the types are correct in the equality before allowing you to run. What do you think?

thanks

@dsyme dsyme changed the title fix equality fix equality to require identical types Jun 7, 2017
@dsyme
Copy link
Collaborator Author

dsyme commented Jun 7, 2017

On screen it looks like this:

image

@dsyme
Copy link
Collaborator Author

dsyme commented Jun 7, 2017

Merging along with a couple of other micro fixes

@dsyme dsyme merged commit 80314f8 into ChrisMarinos:fsharp Jun 7, 2017
@ChrisMarinos
Copy link
Owner

I think this makes sense in general. I'm straining my brain to think back to why I wrote it that way in the first place, and I think the reason might have been to purposely be a little vague as a way to force folks to dig in and learn. It also may have had something to do with allowing people to be flexible when it came to things like integer to float comparison. I'll run through the koans with this change in place and double check, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants