Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate of ditto #2191

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

OnyxAbove
Copy link
Contributor

The program Ditto had a duplicate entry.

I removed:

"WPFInstallditto": {
		"category": "Utilities",
		"choco": "ditto",
		"content": "Ditto",
		"description": "Ditto is an extension to the standard windows clipboard.",
		"link": "https://ditto-cp.sourceforge.io/",
		"winget": "Ditto.Ditto"
},

In favor of:

"WPFInstallditto": {
		"category": "Utilities",
		"choco": "ditto",
		"content": "Ditto (Clipboard Manager)",
		"description": "Ditto is an extension to the Windows Clipboard. You copy something to the Clipboard and Ditto takes what you copied and stores it in a database to retrieve at a later time.",
		"link": "https://github.com/sabrogden/Ditto",
		"winget": "Ditto.Ditto"
},

Because I think that the title "Ditto (Clipboard Manager)" is more helpful than just "Ditto" and that it is more useful to be linked to the GitHub rather than the SourceForge.

@og-mrk
Copy link
Contributor

og-mrk commented Jun 28, 2024

Hello @OnyxAbove
Thanks for opening this PR, but I do want to inform you that there's a PR which does this change, PR #2169 PR by @Owen-3456

With that being said.. if for whatever reason that PR by Owen is rejected, then this PR would probably get merged (personally, I can't see why this PR might get rejected), so it's better to keep it open for Chris to review 👍

"content": "Ditto",
"description": "Ditto is an extension to the standard windows clipboard.",
"link": "https://ditto-cp.sourceforge.io/",
"winget": "Ditto.Ditto"
},
Copy link
Contributor

@og-mrk og-mrk Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
},

@OnyxAbove Forgot to remove the closing curly bracket.

@ChrisTitusTech ChrisTitusTech merged commit a6ad919 into ChrisTitusTech:main Jun 28, 2024
@OnyxAbove
Copy link
Contributor Author

Hello @OnyxAbove Thanks for opening this PR, but I do want to inform you that there's a PR which does this change, PR #2169 PR by @Owen-3456

With that being said.. if for whatever reason that PR by Owen is rejected, then this PR would probably get merged (personally, I can't see why this PR might get rejected), so it's better to keep it open for Chris to review 👍

Hello, sorry for that @og-mrk. How can I find out if there is a duplicate pull request, I tried to find one, but I wasn't able to.

@og-mrk
Copy link
Contributor

og-mrk commented Jun 29, 2024

Hello @OnyxAbove Thanks for opening this PR, but I do want to inform you that there's a PR which does this change, PR #2169 PR by @Owen-3456
With that being said.. if for whatever reason that PR by Owen is rejected, then this PR would probably get merged (personally, I can't see why this PR might get rejected), so it's better to keep it open for Chris to review 👍

Hello, sorry for that @og-mrk. How can I find out if there is a duplicate pull request, I tried to find one, but I wasn't able to.

you can do so by:

  1. Going to Pull Requests tab, and type in keywords like ditto in the search bar, note you can use more advanced filter options when searching, link to GitHub Docs.
  2. Browse through open/merged PRs in Pull Requests tab (maybe someone has done a similar change to what you intent.. but didn't put clear/concise keywords in both Title & Description of their PR).

Hope my answer is sufficient enough, and if there's anything un-clear, or might have another question, then please go ahead and ask 😄

@OnyxAbove
Copy link
Contributor Author

@og-mrk Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants