Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 12 : Project submission (Pair-programming) #36

Merged
merged 45 commits into from Jul 19, 2022
Merged

Milestone 12 : Project submission (Pair-programming) #36

merged 45 commits into from Jul 19, 2022

Conversation

Chrissiku
Copy link
Owner

What we did ♻️

In this project we are working with the real live data from the SpaceX API.
We build a web application for a company that provides commercial and scientific space travel services.
The application will allow users to book rockets and join selected space missions.

We used 🧑‍💼

  • Use React documentation. ✔️
  • Use React components. ✔️
  • Use React props. ✔️
  • Use React Router. ✔️
  • Connect React and Redux. ✔️
  • Handle events in a React app. ✔️
  • Write unit tests with React Testing Library. ✔️
  • Use styles in a React app. ✔️
  • Use React life cycle methods. ✔️
  • Apply React best practices and language style guides in code. ✔️
  • Use store, actions, and reducers in React. ✔️
  • Perform a code review for a team member. ✔️

Technology used 🧑‍💻

  • Major languages: JavaScript, JSX, and CSS
  • Promise-based HTTP: Axios
  • Toolchain: Babel
  • Library and Framework: React, React-redux, Jest, React-test-renderer, Bootstrap
  • Technologies used: Github, Git, Gitflow, and Linters

Project Quick view

Screen

Chrissiku and others added 30 commits July 18, 2022 11:39
Milestone 2 : Initialize the project
Milestone 3: Basic structure af the app and Rockets reducer
4th Milestone: Create Missions basic structure
Milestone 5 : Fetch rockets data
Milestone 7 : Profile reserved rocket
@netlify
Copy link

netlify bot commented Jul 19, 2022

Deploy Preview for space-x-traveler ready!

Name Link
🔨 Latest commit bb10669
🔍 Latest deploy log https://app.netlify.com/sites/space-x-traveler/deploys/62d6bb13e9e2c400082697da
😎 Deploy Preview https://deploy-preview-36--space-x-traveler.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@mikethreels mikethreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Team,

Impressive job, your project looks great and as far as I can tell is ready to be merged on the first review 👏
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Chrissiku
Copy link
Owner Author

Thank you @mikethreels

@Chrissiku Chrissiku merged commit e01bdb3 into master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants