Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 9 : Create event handlers for the buttons #33

Merged
merged 1 commit into from Jul 19, 2022

Conversation

Graycemuthui
Copy link
Collaborator

Description

In this project I achieved the following:

  • Create event handlers for both the leave mission and join mission
  • Used proper Gitflow

Copy link
Owner

@Chrissiku Chrissiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Pull Request Approved! 🏆

Hi @Graycemuthui 👋

This project's milestone is complete! ✔️ 🏁

You did it! 🎉 👏. Your code was very professional 💯 and I can see you have a great chance to be a Great Software Engineer ⛑️.

There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉. And Welcome to Microverse 👋.

Note: You can now take a break even if short before you move on to the next project. Happy 😄 Coding 🖥️! and Have a nice day 🌞.

Highlights 🌟

  • ✔️ Descriptive commmit messsages
  • ✔️ Descriptive PR description
  • ✔️ No linter Errors
  • The code is top-notch! 💯 and have a huge potential.

Cheers and Happy coding!👏👏👏

Important Notes 📝

  • Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
  • Please, remember to tag me in your question so I can receive the notification.

Thank you for your time 🙏 and call me if you need help or clarification ☎️

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Graycemuthui Graycemuthui merged commit 9482298 into dev Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants