Change updateQueue to a Set

ChristianDobbie · Jan 10, 2022 · 7e52927 · 7e52927
1 parent cd31c31
commit 7e52927
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/svc/items.js b/svc/items.js
@@ -16,7 +16,7 @@ const port = config.PORT || config.ITEMS_PORT;
 let discoveredItems;
 let bazaarProducts = [];
 let itemList = {};
-const updateQueue = [];
+const updateQueue = new Set();
 
 (async function init() {
   try {
@@ -72,7 +72,7 @@ app.post('/', (request, response, _callback) => {
   let updates = false;
   items.forEach((item) => {
     const { id } = item;
-    if (!discoveredItems.has(id) || updateQueue.includes(id)) {
+    if (!discoveredItems.has(id) || updateQueue.has(id)) {
       updates = true;
       logger.info(`Found new item ID ${id}`);
       if (item.texture === null) {
@@ -84,6 +84,9 @@ app.post('/', (request, response, _callback) => {
       delete item.id;
       itemList[id] = item;
       discoveredItems.add(id);
+      if (updateQueue.has(id)) {
+        updateQueue.delete(id);
+      }
     }
   });
   if (updates) {
@@ -95,7 +98,7 @@ app.delete('/:id', (request, response, _callback) => {
   const { id } = request.params;
   if (id in itemList) {
     logger.info(`Adding item ${id} to update queue`);
-    updateQueue.push(id);
+    updateQueue.add(id);
   }
   response.json({ status: 'ok' });
 });