Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small frontend adjustments for first integration #11

Closed
15 tasks done
ChristianGerloff opened this issue Oct 15, 2021 · 3 comments · Fixed by #26
Closed
15 tasks done

small frontend adjustments for first integration #11

ChristianGerloff opened this issue Oct 15, 2021 · 3 comments · Fixed by #26
Assignees
Labels
step-review Issues ready to review type-feature

Comments

@ChristianGerloff
Copy link
Owner

ChristianGerloff commented Oct 15, 2021

  • add default start date
  • bug: search string was not updated
  • start with simple table to display results (rayya)
  • replace download component
  • reset limit
  • consider keys
  • provide Search obj as json download
  • provide option to insert plan search string directly ,e.g. [brain-to-brain] AND [hyperscanning]
  • avoid index of csv @kashyapm94
  • provide an option to remove last added chars of string @kashyapm94
  • provide an option to clean the search string @kashyapm94
  • currently no keys are used: results_as_df (set default to true) have to be created earlyer or within seach part @kashyapm94
  • discuss: remove search class
  • reduce deps
  • use multi-page structure
@kashyapm94
Copy link
Collaborator

@ChristianGerloff When you say remove last added chars of string, do you mean remove the last query string?

Example:

If a query string is: [hyperscanning] AND [fNIRS], then when the user clicks the button, fNIRS should be deleted and the final query string should be [hyperscanning]?

ChristianGerloff added a commit that referenced this issue Oct 15, 2021
@ChristianGerloff
Copy link
Owner Author

Hey @kashyapm94, yes, exactly! thanks for clarifying that 😃

kashyapm94 pushed a commit that referenced this issue Oct 17, 2021
kashyapm94 pushed a commit that referenced this issue Oct 17, 2021
@ChristianGerloff ChristianGerloff added the step-execute Under development label Nov 17, 2021
@kashyapm94
Copy link
Collaborator

kashyapm94 commented Nov 20, 2021

@ChristianGerloff Assume that the user chose to insert plain search string directly,e.g. [brain-to-brain] AND [hyperscanning], and then want to delete it. In this case, we have a button that clears the entire string.

Should we also add the option to remove the last added chars of string for this case as mentioned in the comment above or is it only when the user builds the query string instead of entering it manually?

discuss: remove search class

For this task, it makes sense to delete the search module since we no longer need it. What do you think?

ChristianGerloff added a commit that referenced this issue Jul 25, 2022
@ChristianGerloff ChristianGerloff added step-review Issues ready to review and removed step-execute Under development labels Jul 26, 2022
ChristianGerloff added a commit that referenced this issue Jul 26, 2022
* add initial dependencies

* add findpapers #2

+ reduce gitignore

* add shell to ignore

* Feature/frontend (#7)

* update gitignore & add poetry.lock file

* initial structure of the app

* initial structure of the app #1

* add checkbox for the available databases #1

* add datepicker and make the selection of database to true by default

* modify the placement of date picker; add star textbox for APIkeys #1

* first version of search string textbox & join button #1

* update the list of join types and add the search button #1

The join list is updated making None as the default. If the join is None, then the join type is not added to the search string

* slider for the number of results #1

* check if query is empty when button clicked and modify the final query string

* first version of CI file #4

* Update test.yml

* add .coveragerc and update the CI file

* add download button & checkbox for showing results as df #1

* add separate download buttons for csv and bib files #1

* add coverage badge part in the CI file

* update the branch name

* comment out the codecov part in CI file

* delete unwanted comment

* add the features/interface branch of findpapers as submodule

* update gitignore

* uninstall findpapers

* update the findpaper submodule

* Removed submodule findpapers

* add findpapers as submodule in src folder

* add deps of findpapers submodule

* update the branch name

* Updated submodule src/findpapers

* adj integration findpapers #2

* update lock file

* integrate findpapers search with streamlit and save the search in downloads

* adj main for findpapers #11

* del footer

* adj consider keys #11

* make the index param in CSV false

* update variable name

* add json support #11

* add prisma information #15

* update lock file

* append join_type to the list separately

* clean the entire search string  #11

* remove the last added character #11

* add option to insert plain search string directly #11

* add barchart #15

- delete search module

* add ris download #18

* update deps

* refactoring app structure #11 #22

* add search options #23

+ page prefix

* add download btns

* adj start page text

* add prisma viz as page #15

* add manual screening #25

* update deps

* adj gitignore

* refine user infos

* add demo

* adj url demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
step-review Issues ready to review type-feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants