Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added es6 destructuring setting #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

standingdreams
Copy link

@standingdreams standingdreams commented Jan 26, 2018

Adds a new user setting that gives users the option to set an es6 import with or without destructuring.

  • With destructuring, the module is imported per usual.
  • Without destructuring, the module takes the name of the module, removes any dashes, and uses the output as the name for the import.

Considerations

  • Should name be camel cased?
  • If so, should it be an option?
  • Should naming the module be left to the user? If so, I'm unsure how to set tab stops.

@dkadrios
Copy link

I would love to see this get merged. Destructured importing of large packages can really bloat up your built packages without additional tree shaking which is not an option for many people yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants