Update shouldProvide.ts #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some paths like "@/a.js". It's very common in vue-cli project.
MarvinJWendt
reviewed
Dec 7, 2018
MarvinJWendt
suggested changes
Dec 8, 2018
src/shouldProvide.ts
Outdated
| @@ -50,8 +51,15 @@ function startsWithADot(textCurrentLine: string, position: number) { | |||
| && textWithinString[0] === '.'; | |||
| } | |||
|
|
|||
| function startsWithAtPath(textCurrentLine: string, position: number) { | |||
There was a problem hiding this comment.
Suggested change
| function startsWithAtPath(textCurrentLine: string, position: number) { | |
| function startsWithAnAtSymbol(textCurrentLine: string, position: number) { |
Hey, you changed the name as I suggested, but you left the function name itself unchanged.
You should update that too.
Have a nice day 😄
There was a problem hiding this comment.
Sorry about that. I'm outside now so I used github's "Add suggestion to batch" function to merge your change. I'll fix it on Monday.
Co-Authored-By: blackmiaool <blackmiaool@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some paths like "@/a.js".
It's very common in vue-cli project.