Propoerty changed for ping_failures as it counts failures

ChristianTremblay · Sep 7, 2021 · a09cc9c · a09cc9c
1 parent 9de2203
commit a09cc9c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/BAC0/core/devices/Device.py b/BAC0/core/devices/Device.py
@@ -80,7 +80,7 @@ def __init__(self):
         self.auto_save = None
         self.fast_polling = False
         self.vendor_id = 0
-        self.ping_failed = 0
+        self.ping_failures = 0
 
     def __repr__(self):
         return "{}".format(self.asdict)
@@ -803,14 +803,14 @@ def update_description(self, value):
     def ping(self):
         try:
             if self.read_property("objectName") == self.properties.name:
-                self.properties.ping_failed = 0
+                self.properties.ping_failures = 0
                 return True
             else:
-                self.properties.ping_failed += 1
+                self.properties.ping_failures += 1
                 return False
         except NoResponseFromController as e:
             self._log_error("Error in ping : {}".format(e))
-            self.properties.ping_failed += 1
+            self.properties.ping_failures += 1
             return False
 
     def __repr__(self):

diff --git a/BAC0/scripts/Lite.py b/BAC0/scripts/Lite.py
@@ -323,7 +323,7 @@ def ping_registered_devices(self):
                         )
                     )
                     each.ping()
-                    if each.properties.ping_failed > 3:
+                    if each.properties.ping_failures > 3:
                         raise NumerousPingFailures
 
                 except NumerousPingFailures:
@@ -339,7 +339,7 @@ def ping_registered_devices(self):
                 addr = each.properties.address
                 name = self.read("{} device {} objectName".format(addr, device_id))
                 if name == each.properties.name:
-                    each.properties.ping_failed = 0
+                    each.properties.ping_failures = 0
                     self._log.info(
                         "{}|{} is back online, reconnecting.".format(
                             each.properties.name, each.properties.address

diff --git a/BAC0/tasks/Poll.py b/BAC0/tasks/Poll.py
@@ -84,9 +84,11 @@ def device(self):
 
     def task(self):
         if self.device.properties.ping_failures > 0:
-           self.device._log.warning("Ping failed, skipping polling for now. Resending a ping to speed up things")
-           self.device.ping()
-           return 
+            self.device._log.warning(
+                "Ping failed, skipping polling for now. Resending a ping to speed up things"
+            )
+            self.device.ping()
+            return
         try:
             if self.failures >= self.MAX_FAILURES:
                 raise MultiplePollingFailures(