remove instance override for analog points #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se_21.02.25 Release 21.02.25
|
There is a mechanism in local/object.py that will increment instance number if the one provided is already taken. |
|
I think I responded too fast.... I used to just create a bunch of AI, AO without providing instances numbers... but you are saying that if you provide something else, it get changed right ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologise if I've missed something here but I'm trying to get my head around the whole fork/pull-request process!
It seems that the models.py file overrides any "instance" value passed in via
**kwargswith zero, I've removed this override and implemented the already availableset_default_if_not_provided()function.