Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore require php74 #6

Merged
merged 2 commits into from May 29, 2023
Merged

Chore require php74 #6

merged 2 commits into from May 29, 2023

Conversation

kesselb
Copy link
Collaborator

@kesselb kesselb commented May 22, 2023 •
edited

kitinerary-bin/src/BinaryAdapter.php

Line 128 in 84bf87d

$proc = proc_open([__DIR__ . '/../bin/kitinerary-extractor', ...$options], $descriptors, $pipes);

Spread operator requires PHP 7.4.

@kesselb
chore: support psr/log 2.0 and 3.0
a9145cd 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
chore: require at least php7.4
57da2cb 
We are using the spread operator in BinaryAdapter hence it won't work on PHP 7.2 anymore.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb merged commit 46f60f8 into ChristophWurst:master May 29, 2023
4 checks passed
@kesselb kesselb deleted the chore-require-php74 branch May 29, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kesselb