fix(error-equals): update error equals schemas to have the correct syntax #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the syntax for declaring
string[]
in json schema: https://json-schema.org/understanding-json-schema/reference/array.htmlThe current definitions before this change would produce a schema that was an array of objects.
{ [key: string]: any }[]
when used with the https://github.com/bcherny/json-schema-to-typescript packageThe current schemas dont seem to be used in the repo anywhere, and definitely not in the tests, so this wouldnt have been caught here. However the downstream package asl-types does depend on these schemas, which is where i saw this issue.
I have validated in that package that changing
items
->item
did in fact fix the conversion process.Here is the issue created in that package fourTheorem/asl-types#7
And here are the docs for ErrorEquals https://docs.aws.amazon.com/step-functions/latest/dg/concepts-error-handling.html