Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/github-script action to v7 #3

Merged
merged 4 commits into from
May 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/DemoApp/DemoApp.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
<WindowsXamlEnableOverview>true</WindowsXamlEnableOverview>
<AppxPackageSigningEnabled>True</AppxPackageSigningEnabled>
<PackageCertificateThumbprint>64D77511F9EE850C4272A8F375BDC1C0E4EED688</PackageCertificateThumbprint>
<PackageCertificateThumbprint>2365C65A51AB99ADBD3928B4ACF464EEB664B81C</PackageCertificateThumbprint>
<PackageCertificateKeyFile>DemoApp_TemporaryKey.pfx</PackageCertificateKeyFile>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">
Expand Down
Binary file modified .github/DemoApp/DemoApp_TemporaryKey.pfx
Binary file not shown.
14 changes: 7 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
checks: write
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ github.event.workflow_run.head_branch }}

Expand All @@ -25,12 +25,12 @@ jobs:
features: "OptionId.UWPCPP, OptionId.DesktopCPPx64, OptionId.DesktopCPPx86, OptionId.DesktopCPParm64, OptionId.DesktopCPParm"

- name: Setup NuGet
uses: nuget/setup-nuget@v1
uses: nuget/setup-nuget@v2
with:
nuget-version: '6.2.x'

- name: Setup MSBuild
uses: microsoft/setup-msbuild@v1.1
uses: microsoft/setup-msbuild@v2
with:
vs-version: '[17.2,18.0)'

Expand All @@ -51,10 +51,10 @@ jobs:
threat-as-warning-rules: '61'

- name: Upload Certification report 1
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: certification
name: certification-1
path: ${{ steps.certification-1.outputs.report-path }}

- name: Run the WACK of the test project (without ignore rules)
Expand All @@ -67,8 +67,8 @@ jobs:
threat-as-warning-rules: '61'

- name: Upload Certification report 2
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: certification
name: certification-2
path: ${{ steps.certification-2.outputs.report-path }}
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## v1.0.2

- Updated actions/github-script action to v7 (NodeJS upgrade)

## v1.0.1

- Fixed management of optional parameters
Expand Down
4 changes: 2 additions & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ runs:

- name: "Create a check run"
id: check-run
uses: actions/github-script@v6
uses: actions/github-script@v7
env:
sha_workflow: ${{ github.event.workflow_run.head_commit.id }}
sha_pr: ${{ github.event.pull_request.head.sha }}
Expand Down Expand Up @@ -72,7 +72,7 @@ runs:
"${{ inputs.threat-as-warning-rules }}"

- name: "Update the check run conclusion"
uses: actions/github-script@v6
uses: actions/github-script@v7
if: steps.analysis.conclusion != 'skipped'
env:
summary_file: '${{ steps.analysis.outputs.summaryPath }}'
Expand Down
Loading