Fix using timeout specified in settings #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
force-pushed
the
timeout-fix
branch
from
1fe3c9d
to
ad41ae9
Compare
NullSoldier
changed the title
NullSoldier
changed the title
|
this one is very important, would appreciate a new release being made after this is merged |
ChristopherRabotin
added a commit
that referenced
this pull request
Dec 19, 2015
Fix using timeout specified in settings
|
Hi all! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TIMEOUT was being ignored because getattr doesn't work on dictionaries for it's keys. It should use the dict.get to get the settings. I also added the first settings test, yay.