Fixed tests #51
Merged
Fixed tests #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut that PropUntil stalls. This is a strange issue: if measurements are separated by exactly the time step, then it will stall and not propagate at all. If add a full time step, it'll propagate *a bit* and then stall until there is a large delta between the previous and the following step. Weird af.
…t happens, still investigating. Added a WG to try to compensate, does not help, so let me try to fix this without a wait group.
…ough. The weird situation is that I change the pointer, and it seems to work for exactly that one call, but then at the end PropUntil it doesn't care about the change that I did. WTF? I will need to check in PropUntil that the state has been updated correctly.
…al. Otherwises, they're out of sync. Weird af. Don't know what is up. I think there may be a way to make this sequential where the gorouting also does the full update of the KF when a measurement exists and then have the channel reading function not do anything when there is no measurement. I'm starting to think that is my only hope (and it already sounds like disgusting code).
BUG: Changing the time step will lead to a negative wait group, which is further evidence that something is going on where one go-routine is advancing faster the other one. 0015 2017-01-01 09:49:20 +0000 UTC state: [-5043.047850508302 3559.0460654109465 3286.876581144037 -3.715706446671131 -6.448704059501171 1.282882872645048] 0015 2017-01-01 09:49:22 +0000 UTC orbit: [-5050.467503249387 3546.140371857773 3289.4346631090925] [-3.7039434176182806 -6.456984476348821 1.2751980995803665]
… time step shift).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests will fail until ChristopherRabotin/smd#120 is merged.