Implemented Naasz (with personal changes) #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, the argument of perigee test is with 0.016 instead of 0.01 degrees from the passing value. Same goes for the RAAN change (I think). Similarly, decreasing the semi major axis is about 300km off, although the change is a 18Mm change, so it's damn close. Extending the propagation time for the aNeg test does not help (nor does making the distance epsilon smaller), so this is just weird. It's even weirder that these are *single* OE tests, nothing more.
Also understood that Naasz's weights are based on initial and target not on oscultating and target. Changing that for the argument of periapsis does not actually fix the slight difference found. That said, I'll rewrite Naasz's CL as Lyapunov with linear algebra. Should speed things up seriously.
This fixes two tests: the negative inclination and the RAAN.
Some Petropoulos cases work without the eccentricity. Increasing the argument of perigee fails on Ruggerio still within a small value, and I have yet to understand why...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13.
Although argument of perigee changes fail, all other tests go through.