Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open to PRs ? #2

Closed
ben-j69 opened this issue Dec 3, 2020 · 1 comment
Closed

Open to PRs ? #2

ben-j69 opened this issue Dec 3, 2020 · 1 comment

Comments

@ben-j69
Copy link
Contributor

ben-j69 commented Dec 3, 2020

Hello, I might use your library in my app, are you open to pull request to make some fixes in typos and code/dependencies updates?
@Chrisvin
Copy link
Owner

Chrisvin commented Dec 6, 2020

Yes, I'm open to PRs.
But note that EasyReveal was designed with extensibility in mind. If you want to customize the base structure (say, as done in LiquidSwipe), I might not necessarily approve the changes.
In which case, I'd suggest you use your own forked & customized version in your app.

@Chrisvin Chrisvin closed this as completed Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ben-j69 @Chrisvin