Exclude node_modules from Twig linting. #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exclude node_modules from Twig linting.
Motivation / Context
Once theme dependencies are built locally, the
composer cs-checkcommand will often fail when it finds malformed Twig templates in external dependencies. This will exclude those directories from Twig linting.馃憖 I proposed adding this to the default finder in the Twig linting repo. If my idea is accepted there, this PR should be closed.
Testing Instructions / How This Has Been Tested
Required this branch into a repo that previously had this issue, then ran
composer cs-checkand saw it pass with no issues.Screenshots
Documentation
Maybe?