MINT-1788 Remove ui actions from core-dependencies #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegdeezus
changed the title
redux/modals is a pure state part. It is needed by some core actions and can't be removed from core totally. Modals reducer can be replaced in different environment.
olegdeezus
force-pushed
the
feature/mint-1788-remove-ui-actions
branch
from
662c397
to
3f5662f
Compare
olegdeezus
changed the title
e-maximus
previously approved these changes
Sep 10, 2018
Move UserMonitorService and corresponding actions to @chronobank/login-ui package. Start service after session is created
olegdeezus
force-pushed
the
feature/mint-1788-remove-ui-actions
branch
from
de68ee7
to
1d86ba4
Compare
ozalexo
approved these changes
Sep 10, 2018
e-maximus
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redux/modals is a pure state part. It is needed by some core actions
and can't be removed from core totally.
Modals reducer can be replaced in different environment.