Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with negative request/response sizes displayed. #234

Closed
wants to merge 1 commit into from
Closed

Fix an issue with negative request/response sizes displayed. #234

wants to merge 1 commit into from

Conversation

MiSikora
Copy link
Contributor

@MiSikora MiSikora commented Feb 9, 2020

馃摲 Screenshots

Show us what you've changed, we love images.

Screenshot_1581268679
Screenshot_1581269196

馃搫 Context

Why did you change something? Is there an issue to link here? Or an extarnal link?

I introduced a bug with one of the previous PRs.

馃摑 Changes

Which code did you change? How?

I modified the response/request length on the UI level to display at lest 0 as a minimum value.

鈿狅笍 Breaking

Is there something breaking in the API? Any class or method signature changed?

No.

馃摑 How to test

Is there a special case to test your changes?

Run the sample app. Requests and responses should display 0 B instead of -1 B for some of the responses.

馃敭 Next steps

Do we have to plan something else after the merge?

No.

@vbuberen
Copy link
Collaborator

vbuberen commented Feb 9, 2020

Hi again @MiSikora.
It wasn't your bug that you see -1 - this value is returned when contentLength size is unknown (API returned nothing in this header).
You can see more info here: #209
Till the time we introduce our own mechanism of size calculation, I would leave -1, since 0 isn't technically correct.

@MiSikora
Copy link
Contributor Author

MiSikora commented Feb 9, 2020

Oh, ok. I agree it makes sense to show -1 in such cases. I thought I messed something up. I'll close this then. Thanks for the info.

@MiSikora MiSikora closed this Feb 9, 2020
@MiSikora MiSikora deleted the size-ui-bug branch February 9, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants