Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overlapping texts on Overview tab #314

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Fix overlapping texts on Overview tab #314

merged 1 commit into from
Apr 7, 2020

Conversation

vbuberen
Copy link
Collaborator

@vbuberen vbuberen commented Apr 6, 2020

馃摲 Screenshots

Screenshot from the same device (Nexus 5) as in the reported issue.
Screenshot 2020-04-06 at 16 07 30

馃搫 Context

This fix closes #313
To avoid issues with overlapping I added barriers to all items with long labels.

馃摑 Changes

  • Added barriers to items with long labels and constrained items placed below to this barriers.

@vbuberen vbuberen added the bug Something isn't working label Apr 6, 2020
@vbuberen vbuberen requested a review from cortinico April 6, 2020 13:49
@cortinico cortinico added this to the 3.3.0 milestone Apr 7, 2020
cortinico
cortinico approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbuberen vbuberen merged commit 5dfb820 into develop Apr 7, 2020
@vbuberen vbuberen deleted the fix/overview_overlapping branch April 7, 2020 06:14
@vbuberen vbuberen added this to Done and in Snapshot in Chucker board May 23, 2020
@vbuberen vbuberen mentioned this pull request Aug 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Chucker board
  
Done and in Snapshot
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Overlapping texts on Overview tab.
2 participants
@vbuberen @cortinico