Request processing refactor #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2021
cortinico
reviewed
Feb 2, 2021
library/src/main/java/com/chuckerteam/chucker/internal/support/RequestProcessor.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/chuckerteam/chucker/internal/support/RequestProcessor.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/chuckerteam/chucker/internal/support/RequestProcessor.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/chuckerteam/chucker/internal/support/RequestProcessor.kt
Outdated
Show resolved
Hide resolved
|
Great cleanup @MiSikora 🙏 Thanks for moving this forward |
vbuberen
approved these changes
Feb 9, 2021
MiSikora
force-pushed
the
request-processing-refactor
branch
from
98661f5
to
e0881d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Context
Due to mishaps in #542 I'm putting this for review. If there are any comments I'll fix them in this PR and then create a new one with fixes only that target develop. Below is the copy of description from #542.
ChuckerInterceptorwas doing too much and it would be hard to integrate #523 in a sane manner.📝 Changes
I refactored code responsible for requests processing.
LimitingSourcethat replaces method onIOUtilsthat read limited amount of content. Due to thatchucker_body_unexpected_eofmessage is removed as it is now impossible to read too much from in-memory buffers while processing the response.RequestProcessorthat moves away request logic from the interceptor.HttpTransactionhasisRequestBodyPlainTextis now set to false by default and changed to true only when plain text is detected.📎 Related PR
#527
🚫 Breaking
No.
🛠️ How to test
Added some tests. Other than that, sample app should behave the same.
⏱️ Next steps
Similar PR for response to follow. Also PRs fixing some other issues mentioned in #527.