-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert CSV inline #2
Comments
Hello @Paulobezerr. I am glad you enjoyed using the tool. Let's ensure we are on the same page here. If I get you correctly, you are suggesting that the conversion should be done directly in the file being converted and no new file should be created. If that's the case, then the reason I decided not to adopt that option was because I did not want users to lose the contents of the old document due to the conversion. It could be disheartening, especially if the user is not aware that the conversion replaced the previous contents and a Ctrl or Cmd+Z isn't possible. I had the same experience while using a similar tool. What do you think? Giving users the ability to choose how they want the new content presented is something I'll consider, though. |
Also, I didn't really understand your second bullet point. Could you clarify what you meant? Likewise, responding to your first suggestion in the concluding paragraph, I don't think it's possible to do an inline conversion and keep the converted file in a separate endpoint. Correct me if I'm wrong, but I think the only way to keep the converted file in a separate endpoint is by creating a new file. If what you suggest is possible, though, I'm open to ideas on how it can be achieved. |
Thank you for you answer! Probably I did not splain well. Two functionalitiesI have said two endpoints. Convert CSV file to JSON fileIt is the way Advantages
Disvantages:
Convert CSV content to JSONDoesn't matter if there is a saved file or a buffer only tab. Advantages
Disvantages
|
Thanks for clarifying your point. If I get you correctly, in addition to the current functionalities, you want users to:
Please confirm that what I highlighted is what you are implying. |
Yes, that exactly my idea! |
Thanks for the feedback. I'll close this issue when your suggestion is implemented. If you'd love to, you are welcome to work on it. |
As soon as I get time, I'll start. |
Hello, first of all, thank you for your time. This tool is realy good to me and saved my time a lot!
I saw some gaps when we are converting files directly instead of inline convertion:
I think that we should convert inline but keep file convertion in a separated endpoint.
Or if there is a CSV file stored in hard drive, ask to user what he wants.
What do you think?
The text was updated successfully, but these errors were encountered: