Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some open bugs #5

Merged
merged 8 commits into from
Dec 28, 2017
Merged

Fix some open bugs #5

merged 8 commits into from
Dec 28, 2017

Conversation

winitzki
Copy link
Collaborator

@winitzki winitzki commented Dec 28, 2017

  • code generation involving (Option[T] => A) => B was broken
  • type variables are named incorrectly in case class accessors, need alpha-conversion
  • eta-conversion does not work in simplify, need to implement a simplifier for disjunctions

@codecov
Copy link

codecov bot commented Dec 28, 2017

Codecov Report

Merging #5 into master will increase coverage by 2.46%.
The diff coverage is 94.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   88.48%   90.94%   +2.46%     
==========================================
  Files           6        6              
  Lines         408      453      +45     
  Branches       21       27       +6     
==========================================
+ Hits          361      412      +51     
+ Misses         47       41       -6
Impacted Files Coverage Δ
src/main/scala/io/chymyst/ch/TheoremProver.scala 100% <100%> (+12%) ⬆️
src/main/scala/io/chymyst/ch/LJT.scala 97.27% <100%> (+1.41%) ⬆️
src/main/scala/io/chymyst/ch/Macros.scala 100% <100%> (ø) ⬆️
src/main/scala/io/chymyst/ch/Sequent.scala 100% <100%> (ø) ⬆️
src/main/scala/io/chymyst/ch/TypeExpr.scala 62.5% <57.14%> (-2.21%) ⬇️
src/main/scala/io/chymyst/ch/TermExpr.scala 86.33% <94.23%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d38a63...93286ca. Read the comment docs.

@winitzki winitzki merged commit 23ebc07 into master Dec 28, 2017
@winitzki winitzki deleted the feature/fix-option-codegen branch December 28, 2017 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant