Added Redirect Capability #4
Conversation
Added method override to provideAuthService to allow for specifying a redirect and a homepath URL. Added constructor overrides to allow for passthrough of the redirect and homepath URLs a well as the ability to inject the router for the application.
| closable: false // Users are required to log in | ||
| closable: false, // Users are required to log in | ||
| auth: { | ||
| redirectUrl: (this.redirectPath == null ? location.origin : location.origin + this.redirectPath), |
There was a problem hiding this comment.
What happens if you just say location.origin + this.redirectPath here?
There was a problem hiding this comment.
That would probably work as well, string concatenation in Typescript should do the same thing either way.
There was a problem hiding this comment.
Turns out this doesn't work like that. For example if location.origin is http:\example.com and this.redirectPath isn't set, the results of location.origin + this.redirectPath will end up as http:\example.comundefinded
| }); | ||
|
|
||
| constructor(private clientId: string, private domain: string) { | ||
| constructor( clientId: string, domain: string); | ||
| constructor( clientId: string, domain: string, homePath: string, redirectPath: string, router: Router); |
There was a problem hiding this comment.
I wonder why is this signature necessary?
There was a problem hiding this comment.
This seems to be the recommended method of overloading methods in Typescript.
| export function provideAuthService(clientId: string, domain: string): Provider; | ||
| export function provideAuthService(clientId: string, domain: string, homePath: string, redirectPath: string): Provider; | ||
| export function provideAuthService(clientId: string, domain: string, homePath?: string, redirectPath?: string): Provider { | ||
| if(redirectPath == null){ |
There was a problem hiding this comment.
Should this check be on homePath? That is the one that requires router dependency.
There was a problem hiding this comment.
It should be, I'll change that.
changed a comparison from redirectPath to homePath, as that is actually what should be checked.
Added method override to provideAuthService to allow for specifying a
redirect and a homepath URL.
Added constructor overrides to allow for passthrough of the redirect and
homepath URLs a well as the ability to inject the router for the
application.