Support reverse proxying in front of https servers.

Cimpress-MCP · Apr 26, 2015 · 6a987f6 · 6a987f6
1 parent 1fcd1b9
commit 6a987f6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/proxy/config.js b/lib/proxy/config.js
@@ -47,6 +47,10 @@ function ProxyConfig(config) {
       Object.defineProperty(this_obj, 'https_cert_file', { 'value': config.https.cert, writable: false, enumerable: true });
     }
 
+    // If we know that the host behind the reverse proxy is serving https but is not doing so on port 443, we can force
+    // the use of the HTTPS_AGENT by setting the secure config param.
+    Object.defineProperty(this_obj, 'secure', { 'value': config.secure, writable: false, enumerable: true });
+
     // An optional object defining quotas to apply to inbound requests.
     Object.defineProperty(this_obj, 'quotas', { 'value': (config.quotas || {thresholds:{}}), writable: false, enumerable: true});
 

diff --git a/lib/proxy/index.js b/lib/proxy/index.js
@@ -203,7 +203,9 @@ Proxy.prototype.getConnectReverseProxyApp = function() {
     function(req, res) {
       // Proxy a web request to the target port on localhost using the provided agent.
       // If no agent is provided, node-http-proxy will return a connection: close.
-      proxy.web(req, res, {agent: HTTP_AGENT, target: { 'host' : this_obj.config.target_host, 'port' : this_obj.config.to_port }});
+      var agent = this_obj.config.target_port === 443 || this_obj.config.secure ? HTTPS_AGENT : HTTP_AGENT;
+
+      proxy.web(req, res, {agent: agent, target: { 'host' : this_obj.config.target_host, 'port' : this_obj.config.to_port }});
     }
   );
 };