Skip to content
This repository has been archived by the owner on Apr 21, 2020. It is now read-only.

Commit

Permalink
Clean up some comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
ryanbreen committed May 9, 2015
1 parent 8d9d5c3 commit f6ffa8e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
7 changes: 3 additions & 4 deletions lib/proxy/mutators/oauth_param_collector.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,9 @@ module.exports = function() {
// Add query params
oauth1a_signature_utils.collectParams(req, req.query);

// Add POST body params. This will noop if the request is not a POST or is not form urlencoded.
// If the parameter is an oauth param, track it in the oauth_params object for easy lookup. Note that
// it's seriously non-standard to send oauth parameters in the POST body, but DotNetOpenAuth does it
// in some circumstances.
// Add POST body params. This will noop if the request is not a POST or is not form-urlencoded.
// If the parameter is an oauth param, track it for easy lookup. Note that it's seriously non-standard
// to send oauth parameters in the POST body, but DotNetOpenAuth does it in some circumstances.
oauth1a_signature_utils.collectParams(req, req.body);

next();
Expand Down
7 changes: 3 additions & 4 deletions lib/proxy/mutators/oauth_param_generator.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,9 @@ module.exports = function(proxy) {
// Add query params
oauth1a_signature_utils.collectParams(req, req.query);

// Add POST body params. This will noop if the request is not a POST or is not form urlencoded.
// If the parameter is an oauth param, track it in the oauth_params object for easy lookup. Note that
// it's seriously non-standard to send oauth parameters in the POST body, but DotNetOpenAuth does it
// in some circumstances.
// Add POST body params. This will noop if the request is not a POST or is not form-urlencoded.
// If the parameter is an oauth param, track it for easy lookup. Note that it's seriously non-standard
// to send oauth parameters in the POST body, but DotNetOpenAuth does it in some circumstances.
oauth1a_signature_utils.collectParams(req, req.body);

// Retrieve the signature bases. Unlike with signature validation, we know whether the request
Expand Down
2 changes: 1 addition & 1 deletion lib/proxy/oauth/signatures/oauth1a.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ function safelyAddValues(argument_pairs, name, value) {
}

/**
* Loop over the collection and add entries to oauth_params and/or argument_pairs.
* Loop over the collection and add entries to the provided collection.
*/
exports.collectParams = function(req, collection) {

Expand Down

0 comments on commit f6ffa8e

Please sign in to comment.