This repository has been archived by the owner on Apr 21, 2020. It is now read-only.
Handle URL Encoding for Requests #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the oauth validator to ensure that incoming URL paths are decoded
prior to being encoded. This is necessary because without decoding
first, you can potentially end up with double-encoded paths, which will
create signature mis-matches (i.e. /users/{user}/dothis will
double-encode the curly-braces due to the incoming request already being
URL encoded).
ryanbreen
added a commit
that referenced
this pull request
Jun 22, 2015
Handle URL Encoding for Requests
|
LGTM, thanks! |
|
This will be in version 1.5.6 which should make it to NPM in the next couple of minutes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the oauth validator to ensure that incoming URL paths are decoded
prior to being encoded. This is necessary because without decoding
first, you can potentially end up with double-encoded paths, which will
create signature mis-matches (i.e. /users/{user}/dothis will
double-encode the curly-braces due to the incoming request already being
URL encoded).