This repository has been archived by the owner on Apr 21, 2020. It is now read-only.
Fix Signature Encoding Scheme for Parameters #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the OAuth Signature base is calculated and follows the RFC requirement to encode parameters prior to doing anything else (sorting, etc), it is necessary to pass a decoded version of all parameters to the function, and then encode once. Removed extraneous flip-flopping of encodings, which cause an issue if parameters passed have special characters (i.e. spaces, percent symbols, etc).
|
we need some test cases for these. I'm happy to write them if you don't have time. |
|
Hi Ryan, would you mind writing the test cases? I haven't had the time to do so yet. |
|
Will do. |
ryanbreen
added a commit
that referenced
this pull request
Jun 23, 2015
Fix Signature Encoding Scheme for Parameters
| @@ -40,9 +40,9 @@ function normaliseRequestParams(argument_pairs) { | |||
| continue; | |||
| } | |||
| **/ | |||
| args += sprintf("%s=%s", argument_pairs[i][0], argument_pairs[i][1]); | |||
| args += sprintf("%s%%3D%s", argument_pairs[i][0], argument_pairs[i][1]); | |||
There was a problem hiding this comment.
The more I look at it, I think this line is wrong (both before and after edit). A query param with no value and no equals is common and (I think) legal, but this code assumes there's always an equals. This needs more testing and potentially a fix.
There was a problem hiding this comment.
Never mind, RFC is pretty clear on this point: http://oauth.net/core/1.0a/#anchor13
theopak
added a commit
that referenced
this pull request
Oct 7, 2015
Make test less vulnerable to differences in output between versions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the OAuth Signature base is calculated and follows the RFC
requirement to encode parameters prior to doing anything else (sorting,
etc), it is necessary to pass a decoded version of all parameters to the
function, and then encode once. Removed extraneous flip-flopping of
encodings, which cause an issue if parameters passed have special
characters (i.e. spaces, percent symbols, etc).