Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package version and Travis CI to automatically deploy to NPM #17

Merged
merged 1 commit into from Dec 19, 2017

Conversation

indirap
Copy link
Collaborator

@indirap indirap commented Dec 18, 2017

No description provided.

@@ -1,11 +1,21 @@
language: node_js
node_js:
- "5"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing here was automatically fixed when I ran a Travis command on my terminal

Copy link

@mmaruniak mmaruniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- '5'
- '5.1'
- '4'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all of them?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure TBH, but it was already like that so I left it 🙂

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhh ok. It seems this is to test the code against multiple Node versions https://blog.travis-ci.com/first_class_nodejs_support_on_travis_ci

So I'm fine with leaving it as is, since this was supposed to be a non-breaking compatible change.

@indirap indirap merged commit 5a93d97 into master Dec 19, 2017
Copy link

@jboerjes jboerjes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we have multiple node versions in the travis file otherwise I'm good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants