New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package version and Travis CI to automatically deploy to NPM #17
Conversation
@@ -1,11 +1,21 @@ | |||
language: node_js | |||
node_js: | |||
- "5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing here was automatically fixed when I ran a Travis command on my terminal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- '5' | ||
- '5.1' | ||
- '4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need all of them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure TBH, but it was already like that so I left it 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhh ok. It seems this is to test the code against multiple Node versions https://blog.travis-ci.com/first_class_nodejs_support_on_travis_ci
So I'm fine with leaving it as is, since this was supposed to be a non-breaking compatible change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why we have multiple node versions in the travis file otherwise I'm good.
No description provided.