drawtext will return the coordinates of the bounding box of the text #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will have a look at it asap. Will also add some unit tests. |
|
The code looks good to me, just did a small refactoring to make to code a bit more concise. Unfortunately we do not have an easy way right now to unit test drawing functions. |
strobelm
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is very difficult to find out the screen bounds of a text. This small change gives access to the coordinates of the bounding rectangle for a text that has been output through
drawtext. I plan to add this to Cinderella classic, too, but right now there is a semantic problem when using several ports. I will discuss this with @richter-gebert soon, but until then it would be nice to use this in production code already.