-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UUencode #467
Add UUencode #467
Conversation
|
Hey! We need tests for this :D https://github.com/Ciphey/Ciphey/wiki/Testing-your-cracker---decoder |
Hello. This doesn't seem to work for me. I tried putting I also tried just doing |
Ah, that's because it's not actually hooked up to Ciphey. It's not in Note:
In https://github.com/Ciphey/Ciphey/wiki/Adding-your-own-ciphers Please also add your decoder to |
Yes you should add it to init.py, but that's not why it doesn't work for me. I added it locally and tested it, and it doesn't work for some reason. |
I have added a test case and in the test case if you see, the encoded text it has new lines(\n). I think the new lines are missing in your input and that is why the decoder was not working. This is how I encoded the input string
I tested like this
Though it is feasible to make a small change in the code to accept the multi line input string using -t option, I am not sure if I need to do that as well. @bee-san @SkeletalDemise Please advice |
As suggested by @SkeletalDemise, added the support to decode strings without the |
Is it possible to have both newlines and no newlines to work? :) How common is new lines in UUencode? |
@bee-san looks like the uuencode algorithm encodes data in 45 bytes chunk. If the input length is more than 45 bytes, the algorithm will split the data in 45 bytes chunk and then output each of the 45 bytes chunk in a line. So I guess the new lines are common. As of now, the code supports input with or without new lines. The only thing though is if the original text is >45 bytes and the input text to ciphey doesn't have the new line, then the code may not work. It will work with a new line though as given below
|
Hey we're changing from MIT to GPLv3 because some of our projects are licensed with that, do you approve? If you do not approve we will be forced to delete your code and rewrite it 😢 By approving of this change, you are agreeing to re-license the code you wrote under GPLv3. |
I approve of this change
…On Thu, 20 May 2021 at 16:02, Brandon ***@***.***> wrote:
Hey we're changing from MIT to GPLv3 because some of our projects are
licensed with that, do you approve? If you do not approve we will be forced
to delete your code and rewrite it 😢
By approving of this change, you are agreeing to re-license the code you
wrote under GPLv3.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#467 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUPJ5FUFZYMPG56YEK4HOLTOTQMVANCNFSM4SCXXWQQ>
.
--
Regards,
Malathi
|
Closes #433