Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init change and URL addition #400

Merged
merged 12 commits into from Sep 15, 2020
Merged

init change and URL addition #400

merged 12 commits into from Sep 15, 2020

Conversation

MikeMerz
Copy link
Contributor

@MikeMerz MikeMerz commented Sep 9, 2020

I have added the URL coding decoder and updated the init as well,any suggestions on improving are welcomed.

@request-info
Copy link

request-info bot commented Sep 9, 2020

The maintainers of this repository would appreciate it if you could provide more information.

ciphey/basemods/Decoders/URL.py Outdated Show resolved Hide resolved
ciphey/basemods/Decoders/URL.py Outdated Show resolved Hide resolved
ciphey/basemods/Decoders/URL.py Outdated Show resolved Hide resolved
ciphey/basemods/Decoders/__init__.py Outdated Show resolved Hide resolved
ciphey/basemods/Decoders/URL.py Outdated Show resolved Hide resolved
ciphey/basemods/Decoders/URL.py Outdated Show resolved Hide resolved
@bee-san
Copy link
Member

bee-san commented Sep 10, 2020

Hey! Your test fails, This is because you're not using the latest version of master branch, I think -- as we fixed the bug you have yesterday.

Can you pull master branch of Ciphey into your fork, and merge them? :)

If so, I'll accept this PR and you'll be in Ciphey 🥳

@MikeMerz
Copy link
Contributor Author

Hey! Your test fails, This is because you're not using the latest version of master branch, I think -- as we fixed the bug you have yesterday.

Can you pull master branch of Ciphey into your fork, and merge them? :)

If so, I'll accept this PR and you'll be in Ciphey partying_face

Hey, the push was by mistake I was trying to merge the branches

@bee-san bee-san self-requested a review September 10, 2020 18:34
@bee-san
Copy link
Member

bee-san commented Sep 14, 2020

Hey! All your tests are failing :)

@bee-san bee-san self-requested a review September 15, 2020 11:11
@SkeletalDemise SkeletalDemise removed the request for review from bee-san September 15, 2020 13:21
@SkeletalDemise
Copy link
Contributor

@all-contributors please add @MikeMerz for code

@allcontributors
Copy link
Contributor

@SkeletalDemise

I've put up a pull request to add @MikeMerz! 🎉

@SkeletalDemise SkeletalDemise merged commit ed9e4da into Ciphey:master Sep 15, 2020
@SkeletalDemise SkeletalDemise mentioned this pull request Sep 15, 2020
@SkeletalDemise SkeletalDemise linked an issue Sep 16, 2020 that may be closed by this pull request
@SkeletalDemise SkeletalDemise removed a link to an issue Sep 16, 2020
@bee-san
Copy link
Member

bee-san commented May 20, 2021

Hey we're changing from MIT to GPLv3 because some of our projects are licensed with that, do you approve? If you do not approve we will be forced to delete your code and rewrite it 😢

By approving of this change, you are agreeing to re-license the code you wrote under GPLv3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants