Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tap Code Decoder #458

Merged
merged 4 commits into from Oct 1, 2020
Merged

Add Tap Code Decoder #458

merged 4 commits into from Oct 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 1, 2020

i also made a pull request for ciphedists to add the translation for the tap code.
the letter "K" is not supported and is at the current state not possible to implement that but everything else works fine
closes #337

@bee-san
Copy link
Member

bee-san commented Oct 1, 2020

Can you merge with master? I updated it to feature newest cipheydists :)

@ghost
Copy link
Author

ghost commented Oct 1, 2020

Can you merge with master? I updated it to feature newest cipheydists :)

merged it to the latest version. All checks passed :)

@bee-san
Copy link
Member

bee-san commented Oct 1, 2020

Thanks so much! Can I just say how much we appreciate this. You've contributed 2 amazing PRs so far! Outstanding work. You even fixed bugs we couldn't fix 😉

@bee-san bee-san merged commit a3c4d4a into Ciphey:master Oct 1, 2020
@bee-san
Copy link
Member

bee-san commented May 20, 2021

Hey we're changing from MIT to GPLv3 because some of our projects are licensed with that, do you approve? If you do not approve we will be forced to delete your code and rewrite it 😢

By approving of this change, you are agreeing to re-license the code you wrote under GPLv3.

@ghost
Copy link
Author

ghost commented May 20, 2021

Hey we're changing from MIT to GPLv3 because some of our projects are licensed with that, do you approve? If you do not approve we will be forced to delete your code and rewrite it 😢

By approving of this change, you are agreeing to re-license the code you wrote under GPLv3.

I approve the license change you can use my code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Prisoner's Tap Code
1 participant