Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generalize functions, replace recursion with loops and fix bugs #7

Merged
merged 3 commits into from Jan 6, 2023
Merged

fix: generalize functions, replace recursion with loops and fix bugs #7

merged 3 commits into from Jan 6, 2023

Conversation

EricRibeiro
Copy link
Contributor

@EricRibeiro EricRibeiro commented Jan 6, 2023 •
edited

Changes

Issues

@EricRibeiro EricRibeiro changed the title refactor: generalize functions and replace recursion with loops fix: generalize functions, replace recursion with loops and fixes bugs Jan 6, 2023
@EricRibeiro EricRibeiro changed the title fix: generalize functions, replace recursion with loops and fixes bugs fix: generalize functions, replace recursion with loops and fix bugs Jan 6, 2023
@EricRibeiro EricRibeiro mentioned this pull request Jan 6, 2023
Closed
KyleTryon
KyleTryon reviewed Jan 6, 2023
View reviewed changes
index.js
message: "Enter your GitHub API token",
type: "password",
name: "ghToken",
when: VCS === "GitHub",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, didn't know if we could do this

KyleTryon
KyleTryon reviewed Jan 6, 2023
View reviewed changes
index.js
})
);
USER_DATA.projects = repoData.filter((repo) => repo.variables.length > 0);
USER_DATA.projects = repoData.filter((repo) => repo.variables?.length > 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@KyleTryon KyleTryon merged commit 2faa21c into CircleCI-Public:main Jan 6, 2023
@KyleTryon KyleTryon mentioned this pull request Jan 6, 2023
Closed
@EricRibeiro EricRibeiro deleted the refactor branch January 6, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleTryon KyleTryon KyleTryon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@EricRibeiro @KyleTryon