fix: Added handling for different paths for ANDROID_NDK_HOME #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrothstein74
previously approved these changes
Jun 22, 2022
EricRibeiro
suggested changes
Jun 23, 2022
ryanbourdais
force-pushed
the
fix-ndk-installation
branch
from
3d308ba
to
d4986a3
Compare
EricRibeiro
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation, issues
This fix was drafted in response to the following issue: #39
Description
Added conditional to install-ndk command so ANDROID_NDK_HOME will be set either with
$HOME/android-sdk/ndk/<< parameters.version >>or/opt/android/sdk/ndk/<< parameters.version >>with the default being the former