New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change java version command to handle java 17 being installed instead of 11 #74

Merged

ryanbourdais merged 1 commit into main from fix-change-java-version

Mar 31, 2023

Contributor

ryanbourdais commented Mar 28, 2023

This PR does the following changes:

Upgrades the test image for the test-java-version to the new android:2023.03.1 docker image
Widens the net for testing this command, now tests for 8, 11, 17 and 18 to test for both installed versions, one older than the current, and one newer
Improves the name for the change_java_version command
Fixes an issue with installing an older version of java than the current


          fix: change java ver command update to handle 17

0344a74

ryanbourdais requested a review from a team as a code owner

March 28, 2023 17:16

ryanbourdais enabled auto-merge (squash)

March 29, 2023 17:14

JalexChen approved these changes

View reviewed changes

Contributor

JalexChen left a comment

LGTM

ryanbourdais merged commit 8680958 into main

ryanbourdais deleted the fix-change-java-version branch

March 31, 2023 18:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment