Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/boolean check #87

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Fix/boolean check #87

merged 2 commits into from
Jan 2, 2024

Conversation

EricRibeiro
Copy link
Contributor

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

This PR fixes several flags that ship with the start-emulator command. We were checking the flag's existence with true and false instead of 1s and 0s.

@EricRibeiro EricRibeiro requested a review from a team as a code owner January 2, 2024 19:24
@brivu brivu assigned brivu and unassigned brivu Jan 2, 2024
brivu
brivu approved these changes Jan 2, 2024
View reviewed changes
Copy link

@brivu brivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ryanbourdais
ryanbourdais approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@ryanbourdais ryanbourdais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JalexChen
JalexChen approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@JalexChen JalexChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricRibeiro EricRibeiro merged commit 8aef327 into main Jan 2, 2024
2 checks passed
@EricRibeiro EricRibeiro deleted the fix/boolean-check branch January 2, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JalexChen JalexChen JalexChen approved these changes

@brivu brivu brivu approved these changes

@ryanbourdais ryanbourdais ryanbourdais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EricRibeiro @JalexChen @brivu @ryanbourdais