Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify when for setup and install commands #54

Closed
gmemstr opened this issue Oct 2, 2020 · 3 comments
Closed

Ability to specify when for setup and install commands #54

gmemstr opened this issue Oct 2, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gmemstr
Copy link
Contributor

gmemstr commented Oct 2, 2020

Related: CircleCI-Public/aws-s3-orb#6

Within CircleCI, we can run steps even after the previous command failed using when: https://circleci.com/docs/2.0/configuration-reference/#run

This would be helpful for AWS-related actions that would need to be run every time, regardless of failure, to tear down test infrastructure or upload test results.

@dkarp0
Copy link

dkarp0 commented Sep 9, 2021

This would be incredibly useful for us. We're uploading our build artifacts to s3 as circleci artifacts are only valid for 30 days. This often included test results, so we need them even on fail.

Additionally, there isn't a good workaround that I'm aware of! If you need when: always then you essentially cannot use this orb at all

@brivu brivu self-assigned this Dec 20, 2021
@brivu
Copy link
Contributor

brivu commented Dec 20, 2021

@dkarp0,

Thanks for letting us know. I'm going to assign myself this task and will look at it as soon as possible.

Best,
Brian

@brivu
Copy link
Contributor

brivu commented Mar 18, 2022

Closing with CircleCI-Public/aws-s3-orb#6

@brivu brivu closed this as completed Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants