Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[semver:skip] Fixing typo in parameter description #112

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

yaningo
Copy link
Contributor

@yaningo yaningo commented Jun 6, 2022

Checklist

  • [ n/a ] All new jobs, commands, executors, parameters have descriptions
  • [ n/a ] Examples have been added for any significant new features
  • [ n/a ] README has been updated, if necessary

Motivation, issues

The aws-secret-access-key parameter's description (setup command) references the name of the environment variable preceded by $, instead of just the environment variable's name. This is incorrect and could create confusion.

Description

Remove the $ (Dollar sign) that's currently preceding the environment variable's name.

@yaningo yaningo requested a review from a team as a code owner June 6, 2022 14:34
Copy link
Contributor

@brivu brivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@brivu brivu merged commit af74a8a into CircleCI-Public:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants