Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added error messages for missing parameters #116

Merged
merged 1 commit into from
Aug 24, 2022
Merged

fix: added error messages for missing parameters #116

merged 1 commit into from
Aug 24, 2022

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Aug 24, 2022

This PR adds validation to the assume-role-with-web-identity command. The command will fail if the aws cli is not installed or if no OIDC token is available.

@brivu brivu requested a review from a team as a code owner August 24, 2022 19:16
@brivu brivu linked an issue Aug 24, 2022 that may be closed by this pull request
Silient failure for missing context for "aws sts assume-role-with-web-identity" #109
Closed
KyleTryon
KyleTryon approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@KyleTryon KyleTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@brivu brivu merged commit 1c840bd into master Aug 24, 2022
@brivu brivu deleted the add-assume-role-validation branch August 24, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleTryon KyleTryon KyleTryon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Silient failure for missing context for "aws sts assume-role-with-web-identity"
2 participants
@brivu @KyleTryon