fix: role session name #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricRibeiro
reviewed
Jun 20, 2023
EricRibeiro
suggested changes
Jun 20, 2023
|
Unrelated to the PR, but I noticed there is a job in test-deploy called Maybe it was wrongfully renamed during the OT 12 migration? |
brivu
force-pushed
the
fix/role-session-name
branch
from
9e960c5
to
6e7fa1d
Compare
You're right. I made the change. Thank you! |
EricRibeiro
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, job name containing white spaces is valid in CircleCI. However, the
assume-role-with-web-identitycommand uses the job name as the default value for therole-session-nameparameter that gets passed to theaws cli.The issue is that the
aws clicommand does not accept arole-session-namecontain white spaces and throws this error:Member must satisfy regular expression pattern: [\w+=,.@-]*This
PRimplements a fix to check and see if the job name contains white spaces. It it does, the spaces are replaces by-.