Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nounset shell #141

Merged
merged 16 commits into from
Jun 22, 2023
Merged

fix: nounset shell #141

merged 16 commits into from
Jun 22, 2023

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Jun 21, 2023

When a user specifies a shell for an executor in their config, using shell: /bin/bash -o nounset causes scripts with unbound variables to fail.

This PR resolves this issue.

@brivu brivu requested a review from a team as a code owner June 21, 2023 08:00
@brivu brivu self-assigned this Jun 21, 2023
@brivu brivu linked an issue Jun 21, 2023 that may be closed by this pull request
aws-cli/setup fails in shells that disallow unset variables #119
Closed
EricRibeiro
EricRibeiro suggested changes Jun 21, 2023
View reviewed changes
src/scripts/assume_role_with_web_identity.sh Outdated Show resolved Hide resolved
src/scripts/configure.sh Outdated Show resolved Hide resolved
src/scripts/configure.sh Show resolved Hide resolved
src/scripts/install.sh Outdated Show resolved Hide resolved
src/scripts/install.sh Show resolved Hide resolved
src/scripts/install.sh Outdated Show resolved Hide resolved
src/scripts/role_arn_setup.sh Outdated Show resolved Hide resolved
brivu and others added 6 commits June 21, 2023 14:33
@brivu @EricRibeiro
chore: update src/scripts/assume_role_with_web_identity.sh
fdf39ff 
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu @EricRibeiro
chore: update src/scripts/configure.sh
0fece98 
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu @EricRibeiro
chore: update src/scripts/role_arn_setup.sh
67a1dd5 
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu
Merge branch 'master' into fix/nounset-shell
5587d10
@brivu @EricRibeiro
chore: update src/scripts/install.sh
f562208 
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu @EricRibeiro
chore: update src/scripts/install.sh
c131d1a 
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu brivu mentioned this pull request Jun 21, 2023
Merged
@brivu
# This is a combination of 4 commits.
884823c 
# This is the 1st commit message:

fix: unbound variable in config command

# The commit message #2 will be skipped:

# chore: update src/scripts/assume_role_with_web_identity.sh
#
# Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>

# The commit message #3 will be skipped:

# chore: update src/scripts/configure.sh
#
# Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>

# The commit message #4 will be skipped:

# chore: update src/scripts/role_arn_setup.sh
#
# Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
@brivu
fix: merge conflicts
d80722a
@brivu
fix: unbound variable in config command
abd35ba
@brivu
fix: unbound variable in config command
7cb565b
@brivu
fix: address conflicts
fbcce3b
@brivu
fix: add check for white spaces
8c125a9
@brivu brivu merged commit 68298b2 into master Jun 22, 2023
2 checks passed
@brivu brivu deleted the fix/nounset-shell branch June 22, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricRibeiro EricRibeiro EricRibeiro approved these changes

Assignees

@brivu brivu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-cli/setup fails in shells that disallow unset variables
2 participants
@brivu @EricRibeiro