Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: features and bug fixes from pull requests #154

Merged
merged 16 commits into from
Aug 29, 2023
Merged

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Aug 15, 2023

brivu and others added 6 commits August 14, 2023 17:17
In the `install` command, if `override_installed` is set to `true` but `version` is not specified, the orb will attempt to download the AWS CLI from a path including "latest". This won't work; you access the latest version by not specifying a version at all in the URL, ie an empty string.
@brivu brivu requested a review from a team as a code owner August 15, 2023 23:17
@brivu brivu self-assigned this Aug 16, 2023
@brivu brivu changed the title feat: faetures and bug fixes from pull requests feat: features and bug fixes from pull requests Aug 16, 2023
@brivu brivu linked an issue Aug 16, 2023 that may be closed by this pull request
Copy link
Contributor

@EricRibeiro EricRibeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work 💯

src/commands/install.yml Outdated Show resolved Hide resolved
src/scripts/install.sh Outdated Show resolved Hide resolved
src/scripts/install.sh Outdated Show resolved Hide resolved
src/scripts/install.sh Outdated Show resolved Hide resolved
src/scripts/role_arn_setup.sh Show resolved Hide resolved
src/scripts/utils.sh Outdated Show resolved Hide resolved
src/scripts/windows/install.sh Outdated Show resolved Hide resolved
src/scripts/install.sh Outdated Show resolved Hide resolved
src/scripts/install.sh Outdated Show resolved Hide resolved
src/scripts/install.sh Outdated Show resolved Hide resolved
src/scripts/linux/install.sh Outdated Show resolved Hide resolved
src/scripts/macos/install.sh Outdated Show resolved Hide resolved
src/scripts/windows/install.sh Outdated Show resolved Hide resolved
src/scripts/windows/install.sh Outdated Show resolved Hide resolved
src/scripts/windows/install.sh Outdated Show resolved Hide resolved
src/scripts/windows/install.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@EricRibeiro EricRibeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙇

@brivu brivu linked an issue Aug 29, 2023 that may be closed by this pull request
@brivu brivu merged commit 031bcf7 into master Aug 29, 2023
2 checks passed
@brivu brivu deleted the feat/merge-pr-features branch August 29, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: unknown command "env" for "circleci" request for new release that includes fix for Alpine Linux
5 participants