Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add more testing for role_arn_setup command #167

Merged
merged 2 commits into from
Sep 20, 2023
Merged

ci: add more testing for role_arn_setup command #167

merged 2 commits into from
Sep 20, 2023

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Sep 20, 2023

This PR adds additional checks to the integration-test-role-arn-setup test.

After it executes the aws-cli/role_arn_setup command, it logs into aws ecr using the profile that's been configured.

@brivu brivu requested a review from a team as a code owner September 20, 2023 05:20
@brivu brivu linked an issue Sep 20, 2023 that may be closed by this pull request
'role_arn' IS a required argument when calling 'aws-cli/setup' #165
Closed
@brivu brivu self-assigned this Sep 20, 2023
@brivu brivu merged commit 2cf6493 into master Sep 20, 2023
2 checks passed
@brivu brivu deleted the test/role_arn_setup branch September 20, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricRibeiro EricRibeiro EricRibeiro approved these changes

Assignees

@brivu brivu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'role_arn' IS a required argument when calling 'aws-cli/setup'
2 participants
@brivu @EricRibeiro