feat: sanitize role session name #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace all invalid characters with '-' * Trim length to 64 chars
brivu
force-pushed
the
feat/sanitize-role-session-name
branch
from
a49d225
to
a2dac93
Compare
EricRibeiro
approved these changes
Nov 10, 2023
|
I just tried to re-run the job and I'm still experiencing the same errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
role_session_nameparameter can only contain64characters and can only contain uppercase and lowercase letters, digits from 0-9, and the characters=,,,.,@,_, and-.This pull request sanitizes the
role_session_nameparameter, ensuring that it's properly formatted so that theassume_role_with_web_identitycommand does not fail. It also adds testing for this parameter as well.