Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: skip installation if specified version is installed #182

Merged
merged 6 commits into from
Dec 6, 2023

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Nov 30, 2023

If a user specifies a version of the aws cli to install, the orb always uninstalls the any pre-installed version before installing the specified one. It does not check to see if the user's specified version is already installed.

This PR checks to see if the the user's version matches the pre-installed version of the aws-cli. If it does, it skips the installation process.

@brivu brivu requested a review from a team as a code owner November 30, 2023 04:58
@brivu brivu self-assigned this Nov 30, 2023
@brivu brivu linked an issue Nov 30, 2023 that may be closed by this pull request
src/scripts/install.sh Outdated Show resolved Hide resolved
@brivu brivu merged commit 5a92b1f into master Dec 6, 2023
2 checks passed
@brivu brivu deleted the refactor/check-for-version branch December 6, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Installation Flow for Existing CLI Versions
3 participants