Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add pager validation for every install case #183

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: add pager validation for every install case #183

merged 1 commit into from
Dec 5, 2023

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Nov 30, 2023

Currently, the disable_aws_pager parameters is only applied if the AWS CLI was initially absent or if another version is being installed. If the aws-cli is already installed, the parameter is ignored.

This PR ensures that the parameter is always applied

@brivu brivu self-assigned this Nov 30, 2023
@brivu brivu requested a review from a team as a code owner November 30, 2023 07:22
@brivu brivu linked an issue Nov 30, 2023 that may be closed by this pull request
'disable_aws_pager' argument ignored if AWS CLI is already installed #176
Closed
@brivu brivu merged commit 258ffaf into master Dec 5, 2023
2 checks passed
@brivu brivu deleted the fix/toggle_pager branch December 5, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricRibeiro EricRibeiro EricRibeiro approved these changes

Assignees

@brivu brivu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'disable_aws_pager' argument ignored if AWS CLI is already installed
2 participants
@brivu @EricRibeiro